-
Notifications
You must be signed in to change notification settings - Fork 27
Add test coverage to CI #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks! Not as bad as I feared (though it looks pretty bad... lot of missed code is for error handling though). Hopefully the potential rate of increase will encourage people to help out. |
|
@hugovk I'm not seeing any coverage comparisons, and it looks like the main branch can't upload reports (see https://github.com/python/pymanager/actions/runs/14733127892/job/41352261374). Any idea exactly what settings should be tweaked here? Is the token referred to in that build the GitHub token (I disabled write access by default, because we shouldn't ever write directly to the repo from a build, but perhaps codecov needs it?) |
|
A token isn't needed any more, we can set it to to tokenless. https://app.codecov.io/gh/python/pymanager says:
@python/organization-owners Please could you go to https://app.codecov.io/account/gh/python/org-upload-token and select "Not required"?
|
|
@hugovk this is okay to do for the entire org? |
|
Please keep tokens scoped to individual projects. |
|
Yeah, I think so, and it's the default for new orgs: https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token |
Sure, please could you add a token to this repo secrets? |
|
Actually, we already have a I'll open a new PR. Sorry for the needless pings! |

Helps #7.
Run tests with coverage, and send to the terminal and Codecov, so we get reports like https://github.com/hugovk/pymanager/actions/runs/14727134371/job/41332386214#step:8:218 and https://app.codecov.io/gh/hugovk/pymanager/tree/coverage
Fix a reused test name that meant the test wasn't run, found from looking at test coverage results.